[
https://issues.apache.org/jira/browse/HDFS-16213?focusedWorklogId=653066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653066
]
ASF GitHub Bot logged work on HDFS-16213:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/21 15:57
Start Date: 20/Sep/21 15:57
Worklog Time Spent: 10m
Work Description: ferhui commented on a change in pull request #3386:
URL: https://github.com/apache/hadoop/pull/3386#discussion_r712303703
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
##########
@@ -1344,26 +1359,34 @@ public void testDnRestartWithHardLink() {
assertTrue(Files.exists(Paths.get(newReplicaInfo.getBlockURI())));
assertTrue(Files.exists(Paths.get(oldReplicaInfo.getBlockURI())));
- DirectoryScanner scanner = new DirectoryScanner(
- cluster.getDataNodes().get(0).getFSDataset(), conf);
+ // Before starting Dir Scanner, we should enable deleteDuplicateReplicas.
+ FsDatasetSpi<?> fsDataset = cluster.getDataNodes().get(0).getFSDataset();
+ DirectoryScanner scanner = new DirectoryScanner(fsDataset, conf);
+ FsVolumeImpl fsVolume =
+ (FsVolumeImpl) fsDataset.getFsVolumeReferences().get(0);
+ fsVolume.getBlockPoolSlice(fsVolume.getBlockPoolList()[0])
+ .setDeleteDuplicateReplicasForTests(true);
scanner.start();
scanner.run();
- GenericTestUtils.waitFor(new Supplier<Boolean>() {
- @Override public Boolean get() {
- return !Files.exists(Paths.get(oldReplicaInfo.getBlockURI()));
- }
- }, 100, 10000);
+ GenericTestUtils.waitFor(
+ () -> !Files.exists(Paths.get(oldReplicaInfo.getBlockURI())),
+ 100, 10000, "Old replica is not deleted by DirScanner even after "
+ + "10s of waiting has elapsed");
assertTrue(Files.exists(Paths.get(newReplicaInfo.getBlockURI())));
validateFileLen(fs, fileLen, filePath);
- } catch (Exception ex) {
- LOG.info("Exception in testDnRestartWithHardLink ", ex);
- fail("Exception while testing testDnRestartWithHardLink ");
+ // Additional tests to ensure latest replica gets deleted after file
+ // deletion.
+ fs.delete(filePath, false);
+ GenericTestUtils.waitFor(
+ () -> !Files.exists(Paths.get(newReplicaInfo.getBlockURI())),
+ 100, 10000);
} finally {
- if (cluster.isClusterUp()) {
- cluster.shutdown();
+ conf.unset(DFSConfigKeys.DFS_DATANODE_DUPLICATE_REPLICA_DELETION);
Review comment:
Maybe we need to reserve original value and set it finally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653066)
Time Spent: 8.5h (was: 8h 20m)
> Flaky test TestFsDatasetImpl#testDnRestartWithHardLink
> ------------------------------------------------------
>
> Key: HDFS-16213
> URL: https://issues.apache.org/jira/browse/HDFS-16213
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Failure case:
> [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt]
> {code:java}
> [ERROR]
> testDnRestartWithHardLink(org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl)
> Time elapsed: 7.768 s <<< FAILURE![ERROR]
> testDnRestartWithHardLink(org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl)
> Time elapsed: 7.768 s <<< FAILURE!java.lang.AssertionError at
> org.junit.Assert.fail(Assert.java:87) at
> org.junit.Assert.assertTrue(Assert.java:42) at
> org.junit.Assert.assertTrue(Assert.java:53) at
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl.testDnRestartWithHardLink(TestFsDatasetImpl.java:1344)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
