[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=656978&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656978
]
ASF GitHub Bot logged work on HDFS-16242:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/21 02:28
Start Date: 29/Sep/21 02:28
Worklog Time Spent: 10m
Work Description: Neilxzn commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-929771633
cc @aajisaka @adamantal . Would you take some time to review this patch?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 656978)
Time Spent: 50m (was: 40m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
> Affects Versions: 3.4.0
> Reporter: Max Xie
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
> ...
> },
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
> "Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
