[
https://issues.apache.org/jira/browse/HDFS-16254?focusedWorklogId=659787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659787
]
ASF GitHub Bot logged work on HDFS-16254:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/21 18:43
Start Date: 04/Oct/21 18:43
Worklog Time Spent: 10m
Work Description: GauthamBanasandra opened a new pull request #3518:
URL: https://github.com/apache/hadoop/pull/3518
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
* Moved the call
google::protobuf::ShutdownProtobufLibrary()
to main method instead of
AllowSnapshot::HandlePath
since we want the clean-up
tasks to run only when the
program exits.
### How was this patch tested?
Unit tests ran fine. Also, verified
by running the tool locally.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 659787)
Remaining Estimate: 0h
Time Spent: 10m
> Cleanup protobuf on exit of hdfs_allowSnapshot
> ----------------------------------------------
>
> Key: HDFS-16254
> URL: https://issues.apache.org/jira/browse/HDFS-16254
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs++, tools
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Need to move the call google::protobuf::ShutdownProtobufLibrary() to main
> method instead of
> [AllowSnapshot::HandlePath|https://github.com/apache/hadoop/blob/35a8d48872a13438d4c4199b6ef5b902105e2eb2/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/hdfs-allow-snapshot/hdfs-allow-snapshot.cc#L116-L117]
> since we want the clean-up tasks to run only when the program exits.
> The current implementation doesn't cause any issues since
> AllowSnapshot::HandlePath is called only once.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
