[
https://issues.apache.org/jira/browse/HDFS-16265?focusedWorklogId=663202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663202
]
ASF GitHub Bot logged work on HDFS-16265:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/21 18:00
Start Date: 09/Oct/21 18:00
Worklog Time Spent: 10m
Work Description: goiri merged pull request #3536:
URL: https://github.com/apache/hadoop/pull/3536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663202)
Time Spent: 1h (was: 50m)
> Refactor HDFS tool tests for better reuse
> -----------------------------------------
>
> Key: HDFS-16265
> URL: https://issues.apache.org/jira/browse/HDFS-16265
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client, libhdfs++, tools
> Affects Versions: 3.4.0
> Environment: Centos 7, Centos 8, Debian 10, Ubuntu Focal
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, the test cases written in hdfs-tool-test.h isn't easy to reuse.
> Primarily because the expectations are different for each HDFS tool. I
> realized this while I was creating the PR for HDFS-16260. For instance,
> passing more than one argument is erroneous to hdfs_allowSnapshot while it's
> the only valid scenario for hdfs_deleteSnapshot.
> Thus, it won't be possible to reuse the test cases without decoupling the
> expectations from the test case definitions. The solution here is to move the
> expectations to the corresponding mock classes and invoke the call to set
> them up in the test cases after the creation of mock instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
