[ 
https://issues.apache.org/jira/browse/HDFS-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chengwei Wang updated HDFS-16271:
---------------------------------
    Description: 
When we started routers with dfs.federation.router.quota.enable=false, and try 
to setQuota through them, NullPointerException caught.

The cuase of NPE is that the Router#quotaManager not initialized when 
dfs.federation.router.quota.enable=false,
but when executing setQuota rpc request inside router, we wolud use it in 
method Quota#isMountEntry without null check .

I think it's better to check whether Router#quotaManager is null, and throw a 
IOException with readable message if null.

> NullPointerException when setQuota through routers with 
> dfs.federation.router.quota.enable=false.
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-16271
>                 URL: https://issues.apache.org/jira/browse/HDFS-16271
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Chengwei Wang
>            Assignee: Chengwei Wang
>            Priority: Major
>
> When we started routers with dfs.federation.router.quota.enable=false, and 
> try to setQuota through them, NullPointerException caught.
> The cuase of NPE is that the Router#quotaManager not initialized when 
> dfs.federation.router.quota.enable=false,
> but when executing setQuota rpc request inside router, we wolud use it in 
> method Quota#isMountEntry without null check .
> I think it's better to check whether Router#quotaManager is null, and throw a 
> IOException with readable message if null.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to