[
https://issues.apache.org/jira/browse/HDFS-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429535#comment-17429535
]
Ayush Saxena commented on HDFS-16271:
-------------------------------------
v002 LGTM +1
Committed to trunk and branch-3.3.
Thanx [~smarthan] for the contribution and [~elgoiri] for the review!!
> RBF: NullPointerException when setQuota through routers with quota disabled
> ---------------------------------------------------------------------------
>
> Key: HDFS-16271
> URL: https://issues.apache.org/jira/browse/HDFS-16271
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Chengwei Wang
> Assignee: Chengwei Wang
> Priority: Major
> Fix For: 3.3.1
>
> Attachments: HDFS-16271.001.patch, HDFS-16271.002.patch
>
>
> When we started routers with *dfs.federation.router.quota.enable=false*, and
> try to setQuota through them, NullPointerException caught.
> The cuase of NPE is that the Router#quotaManager not initialized when
> dfs.federation.router.quota.enable=false,
> but when executing setQuota rpc request inside router, we wolud use it in
> method Quota#isMountEntry without null check .
> I think it's better to check whether Router#isQuotaEnabled is true before use
> Router#quotaManager, and throw an IOException with readable message if need.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
