[
https://issues.apache.org/jira/browse/HDFS-16266?focusedWorklogId=666735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666735
]
ASF GitHub Bot logged work on HDFS-16266:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 07:13
Start Date: 19/Oct/21 07:13
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3538:
URL: https://github.com/apache/hadoop/pull/3538#discussion_r731559954
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -369,11 +369,22 @@ public static int getCallRetryCount() {
}
/** Returns the remote side ip address when invoked inside an RPC
- * Returns null incase of an error.
+ * Returns null in case of an error.
*/
public static InetAddress getRemoteIp() {
Call call = CurCall.get();
- return (call != null ) ? call.getHostInetAddress() : null;
+ return (call != null) ? call.getHostInetAddress() : null;
+ }
+
+ /**
+ * Returns the remote side port when invoked inside an RPC
+ * Returns an empty string in case of an error.
+ */
+ public static String getRemoteIpAndPort() {
+ Call call = CurCall.get();
+ return (call != null) ?
+ new StringBuffer().append(call.getHostInetAddress()).
+ append(":").append(call.getRemotePort()).toString() : "";
Review comment:
> StringBuffer is thread safe and that's why it is slower than
StringBuilder. Here I think using '+' is sufficient to concatenate strings
because '+' is translated to StringBuilder when compiled.
Thanks @aajisaka for your suggestion, I made some updates. PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 666735)
Time Spent: 2h 20m (was: 2h 10m)
> Add remote port information to HDFS audit log
> ---------------------------------------------
>
> Key: HDFS-16266
> URL: https://issues.apache.org/jira/browse/HDFS-16266
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> In our production environment, we occasionally encounter a problem where a
> user submits an abnormal computation task, causing a sudden flood of
> requests, which causes the queueTime and processingTime of the Namenode to
> rise very high, causing a large backlog of tasks.
> We usually locate and kill specific Spark, Flink, or MapReduce tasks based on
> metrics and audit logs. Currently, IP and UGI are recorded in audit logs, but
> there is no port information, so it is difficult to locate specific processes
> sometimes. Therefore, I propose that we add the port information to the audit
> log, so that we can easily track the upstream process.
> Currently, some projects contain port information in audit logs, such as
> Hbase and Alluxio. I think it is also necessary to add port information for
> HDFS audit logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
