[ 
https://issues.apache.org/jira/browse/HDFS-16277?focusedWorklogId=668401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668401
 ]

ASF GitHub Bot logged work on HDFS-16277:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/21 13:15
            Start Date: 21/Oct/21 13:15
    Worklog Time Spent: 10m 
      Work Description: prasad-acit commented on a change in pull request #3559:
URL: https://github.com/apache/hadoop/pull/3559#discussion_r733664093



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/AvailableSpaceBlockPlacementPolicy.java
##########
@@ -77,6 +86,16 @@ public void initialize(Configuration conf, FSClusterStats 
stats,
           + " is less than 0.5 so datanodes with more used percent will"
           + " receive  more block allocations.");
     }
+
+    if (balancedSpaceTolerance > 20 || balancedSpaceTolerance < 0) {
+      LOG.warn("The value of "
+          + 
DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_TOLERANCE_KEY

Review comment:
       It would be great, if you can print the use configured value here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 668401)
    Time Spent: 3h  (was: 2h 50m)

> improve decision in AvailableSpaceBlockPlacementPolicy
> ------------------------------------------------------
>
>                 Key: HDFS-16277
>                 URL: https://issues.apache.org/jira/browse/HDFS-16277
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: block placement
>    Affects Versions: 3.3.1
>            Reporter: guo
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Hi 
> In product environment,we may meet two or more datanode usage reaches nealy 
> 100%,for exampe 99.99%,98%,97%.
> if we configure `AvailableSpaceBlockPlacementPolicy` , we also have the 
> chance to choose the 99.99%(assume it is the highest usage),for we treat the 
> two choosen datanode as the same usage if their storage usage are different 
> within 5%.
> but this is not what we want, so i suggest we can improve the decision.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to