[
https://issues.apache.org/jira/browse/HDFS-16283?focusedWorklogId=671756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-671756
]
ASF GitHub Bot logged work on HDFS-16283:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/21 02:10
Start Date: 29/Oct/21 02:10
Worklog Time Spent: 10m
Work Description: symious commented on a change in pull request #3595:
URL: https://github.com/apache/hadoop/pull/3595#discussion_r738886825
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
##########
@@ -765,6 +765,14 @@ BatchedDirectoryListing getBatchedListing(
@Idempotent
void renewLease(String clientName) throws IOException;
+ /**
+ * The functionality is the same as renewLease(clientName). This is to
support
+ * router based FileSystem to newLease against a specific target FileSystem
instead
+ * of all the target FileSystems in each call.
+ */
+ @Idempotent
+ void renewLease(String clientName, String nsId) throws IOException;
Review comment:
In a RBF cluster, user shouldn't be aware of the Namespace he's trying
to operate.
If we are adding new protocols, maybe we can add "renewLease(String
clientName, String path)" and let Router do the resolve from path to namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 671756)
Time Spent: 40m (was: 0.5h)
> RBF: improve renewLease() to call only a specific NameNode rather than make
> fan-out calls
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-16283
> URL: https://issues.apache.org/jira/browse/HDFS-16283
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Aihua Xu
> Assignee: Aihua Xu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently renewLease() against a router will make fan-out to all the
> NameNodes. Since renewLease() call is so frequent and if one of the NameNodes
> are slow, then eventually the router queues are blocked by all renewLease()
> and cause router degradation.
> We will make a change in the client side to keep track of NameNode Id in
> additional to current fileId so routers understand which NameNodes the client
> is renewing lease against.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
