[
https://issues.apache.org/jira/browse/HDFS-16290?focusedWorklogId=672264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-672264
]
ASF GitHub Bot logged work on HDFS-16290:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/21 00:11
Start Date: 30/Oct/21 00:11
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3600:
URL: https://github.com/apache/hadoop/pull/3600#discussion_r739582404
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
##########
@@ -378,7 +378,7 @@ void verifyAndSetNamespaceInfo(BPServiceActor actor,
NamespaceInfo nsInfo)
if(nsInfo.getState() == HAServiceState.ACTIVE
&& bpServiceToActive == null) {
- LOG.info("Acknowledging ACTIVE Namenode during handshake" + actor);
+ LOG.info("Acknowledging ACTIVE Namenode during handshake " + actor);
Review comment:
I agree with @ayushtkn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 672264)
Time Spent: 1h 10m (was: 1h)
> Make log more standardized when executing verifyAndSetNamespaceInfo()
> ---------------------------------------------------------------------
>
> Key: HDFS-16290
> URL: https://issues.apache.org/jira/browse/HDFS-16290
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 2.9.2
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Attachments: screenshot-1.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When verifyAndSetNamespaceInfo() is executed, the log will record some
> information. E.g:
> '
> 2021-10-27 18:08:36,242 [50867]-INFO
> [Thread-33:BPOfferService@376]-Acknowledging ACTIVE Namenode during
> handshakeBlock pool BP-597961518-xxx.xxx.xxx.xxx-1534758275943 (Datanode Uuid
> 9b2aedc9-f8b2 -4ee2-b99f-877bc6e42c87) service to
> xxxx.xxx.xxx.org/xxxx.xxx.xxx.xxx:8021
> '
> Here, the connection between the'handshake' and the'Block pool' is too tight,
> and the readability is not good.
> !screenshot-1.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
