[ 
https://issues.apache.org/jira/browse/HDFS-16291?focusedWorklogId=674412&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674412
 ]

ASF GitHub Bot logged work on HDFS-16291:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Nov/21 07:15
            Start Date: 03/Nov/21 07:15
    Worklog Time Spent: 10m 
      Work Description: jianghuazhu commented on a change in pull request #3602:
URL: https://github.com/apache/hadoop/pull/3602#discussion_r741662220



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
##########
@@ -993,15 +993,13 @@ public long getNsDelta() {
     private final QuotaDelta quotaDelta;
 
     /**
-     * @param bsps
- *          block storage policy suite to calculate intended storage type

Review comment:
       Thanks @ferhui for the comment and review.
   I will update it later.
   The new style will look like this:
   
![image](https://user-images.githubusercontent.com/6416939/140021341-f0016022-613a-4de2-a658-a63c336b2b14.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 674412)
    Time Spent: 1.5h  (was: 1h 20m)

> Make the comment of INode#ReclaimContext more standardized
> ----------------------------------------------------------
>
>                 Key: HDFS-16291
>                 URL: https://issues.apache.org/jira/browse/HDFS-16291
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: documentation, namenode
>    Affects Versions: 3.4.0
>            Reporter: JiangHua Zhu
>            Assignee: JiangHua Zhu
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: image-2021-10-31-20-25-08-379.png
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In the INode#ReclaimContext class, there are some comments that are not 
> standardized enough.
> E.g:
>  !image-2021-10-31-20-25-08-379.png! 
> We should make comments more standardized. This will be more readable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to