[
https://issues.apache.org/jira/browse/HDFS-16234?focusedWorklogId=680373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680373
]
ASF GitHub Bot logged work on HDFS-16234:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/21 17:35
Start Date: 11/Nov/21 17:35
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #3469:
URL: https://github.com/apache/hadoop/pull/3469#discussion_r747693806
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/IncrementalBlockReportManager.java
##########
@@ -212,6 +212,8 @@ void sendIBRs(DatanodeProtocol namenode,
DatanodeRegistration registration,
namenode.blockReceivedAndDeleted(registration, bpid, reports);
success = true;
} finally {
+ /* set blocks to zero */
+ this.dnMetrics.resetBlocksInPendingIBR();
Review comment:
Couldn't check in detail but shouldn't this be in success block? In case
it isn't success, it puts the blocks back into the queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 680373)
Time Spent: 50m (was: 40m)
> Improve DataNodeMetrics to initialize IBR more reasonable
> ---------------------------------------------------------
>
> Key: HDFS-16234
> URL: https://issues.apache.org/jira/browse/HDFS-16234
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> DataNode performs DataNodeMetrics to initialize IBR once before sending IBR,
> so there may be data deviation. It should be processed after sending the IBR
> to the NameNode. This seems more reasonable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
