[
https://issues.apache.org/jira/browse/HDFS-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183732#comment-13183732
]
Aaron T. Myers commented on HDFS-2773:
--------------------------------------
Looking good, Todd. I verified that the test passes with this fix, and fails
without it.
My only suggestion would be to add a comment in the OP_CLOSE case to mention
that this code will only be reached when loading old edits log versions.
+1 once the above is addressed.
> HA: reading edit logs from an earlier version leaves blocks in
> under-construction state
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-2773
> URL: https://issues.apache.org/jira/browse/HDFS-2773
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Attachments: hadoop-1.0-multiblock-file.tgz, hdfs-2773.txt
>
>
> In HDFS-2602, the code for applying OP_ADD and OP_CLOSE was changed a bit,
> and the new code has the following problem: if an OP_CLOSE includes new
> blocks (ie not previously seen in an OP_ADD) then those blocks will remain in
> the "under construction" state rather than being marked "complete". This is
> because {{updateBlocks}} always creates {{BlockInfoUnderConstruction}}
> regardless of the opcode. This bug only affects the upgrade path, since in
> trunk we always persist blocks with OP_ADDs before we call OP_CLOSE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
