[
https://issues.apache.org/jira/browse/HDFS-16359?focusedWorklogId=688539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-688539
]
ASF GitHub Bot logged work on HDFS-16359:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/21 09:53
Start Date: 01/Dec/21 09:53
Worklog Time Spent: 10m
Work Description: ayushtkn commented on pull request #3731:
URL: https://github.com/apache/hadoop/pull/3731#issuecomment-983471955
One doubt here:
What I could decode, We try on the default namespace, if it fails. We do:
```
Set<FederationNamespaceInfo> nssWithoutFailed = getNameSpaceInfo(nss, nsId);
return invokeOnNs(method, clazz, ioe, nssWithoutFailed);
```
`getNameSpaceInfo(nss, nsId)` -> This returns the namespaces, removing the
already tried namespace.
Then,
`return invokeOnNs(method, clazz, ioe, nssWithoutFailed)` -> This just tries
on the first namespace returned above.
By the code inside the method `invokeOnNs`:
```
String nsId = nss.iterator().next().getNameserviceId();
return rpcClient.invokeSingle(nsId, method, clazz);
```
So, if the first namespace returned after excluding the default namespace is
also down. Then we would still get an error, right? despite having other
namespace being available? Shouldn't this be a invokeSequential kind of stuff,
try one by one all the namespaces until you get the result. Am I missing
something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 688539)
Time Spent: 3h 10m (was: 3h)
> RBF: RouterRpcServer#invokeAtAvailableNs does not take effect when retrying
> ---------------------------------------------------------------------------
>
> Key: HDFS-16359
> URL: https://issues.apache.org/jira/browse/HDFS-16359
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> RouterRpcServer#invokeAtAvailableNs does not take effect when retrying. See
> HDFS-15543.
> The original code of RouterRpcServer#getNameSpaceInfo looks like this:
> {code:java}
> private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) {
> Set<FederationNamespaceInfo> namespaceInfos = new HashSet<>();
> for (FederationNamespaceInfo ns : namespaceInfos) {
> if (!nsId.equals(ns.getNameserviceId())) {
> namespaceInfos.add(ns);
> }
> }
> return namespaceInfos;
> } {code}
> And _namespaceInfos_ is always empty here.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
