[
https://issues.apache.org/jira/browse/HDFS-16373?focusedWorklogId=691642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-691642
]
ASF GitHub Bot logged work on HDFS-16373:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/21 11:01
Start Date: 07/Dec/21 11:01
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3756:
URL: https://github.com/apache/hadoop/pull/3756#discussion_r763872378
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
##########
@@ -2775,14 +2775,23 @@ public void waitActive(int nnIndex) throws IOException {
DFSClient client = new DFSClient(addr, conf);
// ensure all datanodes have registered and sent heartbeat to the namenode
- while (shouldWait(client.datanodeReport(DatanodeReportType.LIVE), addr)) {
- try {
+ int failedCount = 0;
+ try {
+ while (shouldWait(client.datanodeReport(DatanodeReportType.LIVE), addr))
{
LOG.info("Waiting for cluster to become active");
Thread.sleep(100);
- } catch (InterruptedException e) {
}
+ } catch (IOException e) {
+ failedCount++;
+ // Cached RPC connection to namenode, if any, is expected to fail once
+ if (failedCount > 1) {
Review comment:
Now that we have kept entire while loop within try-catch, `failedCount`
will be `1` here due to `failedCount++` and then we exit from try-catch so
`failedCount` will never be recalculated. Recalculation will be possible only
if try-catch is kept within while loop. Based on WARN log message, it seems
perhaps that's what we should do (i.e. add retries within while loop, so
try-catch inside while loop)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 691642)
Time Spent: 0.5h (was: 20m)
> Fix MiniDFSCluster restart in case of multiple namenodes
> --------------------------------------------------------
>
> Key: HDFS-16373
> URL: https://issues.apache.org/jira/browse/HDFS-16373
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In case of multiple namenodes, if more than one namenode are restarted, it
> fails. Since the restartNamenode checks for all the namenodes to get up, But
> if 2 namenodes are down, and we restart one, the other namenode won't be up,
> so restart fails.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
