[
https://issues.apache.org/jira/browse/HDFS-16375?focusedWorklogId=696494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696494
]
ASF GitHub Bot logged work on HDFS-16375:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/21 09:56
Start Date: 15/Dec/21 09:56
Worklog Time Spent: 10m
Work Description: tasanuma commented on a change in pull request #3769:
URL: https://github.com/apache/hadoop/pull/3769#discussion_r769458969
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -2763,20 +2765,20 @@ public boolean processReport(final DatanodeID nodeID,
if (namesystem.isInStartupSafeMode()
&& !StorageType.PROVIDED.equals(storageInfo.getStorageType())
&& storageInfo.getBlockReportCount() > 0) {
- blockLog.info("BLOCK* processReport 0x{}: "
+ blockLog.info("BLOCK* processReport 0x{} with fullBrLeaseId 0x{}: "
Review comment:
@tomscut Thanks for the PR.
`fullBrLeaseID` is a variable name. I prefer to use "lease ID" in the log
message.
```suggestion
blockLog.info("BLOCK* processReport 0x{} with lease ID 0x{}: "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 696494)
Time Spent: 40m (was: 0.5h)
> The FBR lease ID should be exposed to the log
> ---------------------------------------------
>
> Key: HDFS-16375
> URL: https://issues.apache.org/jira/browse/HDFS-16375
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Our Hadoop version is 3.1.0. We encountered HDFS-12914 and HDFS-14314 in the
> production environment.
> When locating the problem, the *fullBrLeaseId* was not exposed in the log,
> which caused some difficulties. We should expose it to the log.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
