[ 
https://issues.apache.org/jira/browse/HDFS-16371?focusedWorklogId=704039&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-704039
 ]

ASF GitHub Bot logged work on HDFS-16371:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jan/22 15:06
            Start Date: 05/Jan/22 15:06
    Worklog Time Spent: 10m 
      Work Description: tasanuma commented on a change in pull request #3753:
URL: https://github.com/apache/hadoop/pull/3753#discussion_r778893651



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -127,6 +142,21 @@ public void run() {
 
             detectAndUpdateDiskOutliers(metadataOpStats, readIoStats,
                 writeIoStats);
+
+            // Sort the slow disks by latency and .

Review comment:
       @tomscut Happy New Year! Sorry for taking a long time.
   The comment in this line seems incomplete. Could you fix or remove it? Then 
+1 from me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 704039)
    Time Spent: 2h 40m  (was: 2.5h)

> Exclude slow disks when choosing volume
> ---------------------------------------
>
>                 Key: HDFS-16371
>                 URL: https://issues.apache.org/jira/browse/HDFS-16371
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: tomscut
>            Assignee: tomscut
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently, the datanode can detect slow disks. See HDFS-11461.
> And after HDFS-16311, the slow disk information we collected is more accurate.
> So we can exclude these slow disks according to some rules when choosing 
> volume. This will prevents some slow disks from affecting the throughput of 
> the whole datanode.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to