[
https://issues.apache.org/jira/browse/HDFS-16411?focusedWorklogId=708789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708789
]
ASF GitHub Bot logged work on HDFS-16411:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/22 01:27
Start Date: 14/Jan/22 01:27
Worklog Time Spent: 10m
Work Description: yulongz commented on a change in pull request #3878:
URL: https://github.com/apache/hadoop/pull/3878#discussion_r784444888
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouter.java
##########
@@ -223,10 +223,14 @@ public void testRouterMetricsWhenDisabled() throws
Exception {
@Test
public void testSwitchRouter() throws IOException {
- assertRouterHeartbeater(true, true);
- assertRouterHeartbeater(true, false);
- assertRouterHeartbeater(false, true);
- assertRouterHeartbeater(false, false);
+ assertRouterHeartbeater(true,true, true);
Review comment:
In the latest commit e208d71c30e8f1cdc50ba7953bb7f05637a8d2fe , it has
been done.
```suggestion
assertRouterHeartbeater(true, true, true);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708789)
Time Spent: 1.5h (was: 1h 20m)
> RBF: RouterId is NULL when set dfs.federation.router.rpc.enable=false
> ---------------------------------------------------------------------
>
> Key: HDFS-16411
> URL: https://issues.apache.org/jira/browse/HDFS-16411
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Reporter: YulongZ
> Priority: Major
> Labels: pull-request-available
> Attachments: HDFS-16411.000.patch, HDFS-16411.001.patch,
> HDFS-16411.002.patch, HDFS-16411.003.patch, HDFS-16411.004.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When dfs.federation.router.rpc.enable=false, routerid is null, but
> RouterHeartbeatService need updateStateStore() with routerId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
