[ 
https://issues.apache.org/jira/browse/HDFS-16424?focusedWorklogId=710212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710212
 ]

ASF GitHub Bot logged work on HDFS-16424:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jan/22 01:56
            Start Date: 18/Jan/22 01:56
    Worklog Time Spent: 10m 
      Work Description: hfutatzhanghb commented on a change in pull request 
#3884:
URL: https://github.com/apache/hadoop/pull/3884#discussion_r786365987



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -3158,6 +3161,9 @@ private void requeueCall(Call call)
         throws IOException, InterruptedException {
       try {
         internalQueueCall(call, false);
+        long deltaNanos = Time.monotonicNowNanos() - call.timestampNanos;

Review comment:
       Hi, @tasanuma , thanks a lot for reviewing.  yes, it is the same time 
when calculated in internalQueueCall(call, false).
   But in fact, this time is REQUEUE time , original implementation does not 
record this time. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 710212)
    Time Spent: 1h 10m  (was: 1h)

> Add a new rpcMetric called requeueTime
> --------------------------------------
>
>                 Key: HDFS-16424
>                 URL: https://issues.apache.org/jira/browse/HDFS-16424
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: zhanghaobo
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When observer namenode read enabled,  if `call.getClientStateId() > 
> alignmentContext.getLastSeenStateId()`, the rpc call will be requeued to 
> callQueue.
> we need to know rpc requeue metrics to monitor requeue call and its 
> performance.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to