[
https://issues.apache.org/jira/browse/HDFS-16428?focusedWorklogId=711934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711934
]
ASF GitHub Bot logged work on HDFS-16428:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 09:18
Start Date: 20/Jan/22 09:18
Worklog Time Spent: 10m
Work Description: wojiaodoubao commented on a change in pull request
#3898:
URL: https://github.com/apache/hadoop/pull/3898#discussion_r788551958
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
##########
@@ -339,6 +339,13 @@ public boolean isFile() {
return false;
}
+ public boolean isSetStoragePolicy() {
Review comment:
A minor comment. It will be good if we add a comment to this method.
People may confuse about "inheriting storage policy from its parent" and
"containing storage policy itself". Add a comment like getStoragePolicyID() and
getLocalStoragePolicyID().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 711934)
Time Spent: 1h 10m (was: 1h)
> Source path setted storagePolicy will cause wrong typeConsumed in rename
> operation
> -----------------------------------------------------------------------------------
>
> Key: HDFS-16428
> URL: https://issues.apache.org/jira/browse/HDFS-16428
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, namenode
> Reporter: lei w
> Assignee: lei w
> Priority: Major
> Labels: pull-request-available
> Attachments: example.txt
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When compute quota in rename operation , we use storage policy of the target
> directory to compute src quota usage. This will cause wrong value of
> typeConsumed when source path was setted storage policy. I provided a unit
> test to present this situation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
