[
https://issues.apache.org/jira/browse/HDFS-16427?focusedWorklogId=715539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715539
]
ASF GitHub Bot logged work on HDFS-16427:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 08:57
Start Date: 26/Jan/22 08:57
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3888:
URL: https://github.com/apache/hadoop/pull/3888#discussion_r792424055
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -4047,6 +4047,14 @@ private void
chooseExcessRedundancyStriped(BlockCollection bc,
List<DatanodeStorageInfo> replicasToDelete = placementPolicy
.chooseReplicasToDelete(nonExcess, candidates, (short) 1,
excessTypes, null, null);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Choose redundant EC replicas to delete from blk_{} which
is located in {}",
+ sblk.getBlockId(), storage2index);
+ LOG.debug("Storages with candidate blocks to be deleted: {}",
candidates);
+ LOG.debug("Storages with blocks to be deleted: {}",
replicasToDelete);
+ }
+ Preconditions.checkArgument(candidates.containsAll(replicasToDelete),
+ "The EC replicas to be deleted is not in the candidate list");
Review comment:
I am sorry. And I updated it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715539)
Time Spent: 2.5h (was: 2h 20m)
> Add debug log for BlockManager#chooseExcessRedundancyStriped
> ------------------------------------------------------------
>
> Key: HDFS-16427
> URL: https://issues.apache.org/jira/browse/HDFS-16427
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Reporter: tomscut
> Assignee: tomscut
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> To solve this issue
> [HDFS-16420|https://issues.apache.org/jira/browse/HDFS-16420] , we added some
> debug logs, which were also necessary. If there are other problems, we set
> the log level to DEBUG, which is convenient to analyze it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
