[
https://issues.apache.org/jira/browse/HDFS-16452?focusedWorklogId=728697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-728697
]
ASF GitHub Bot logged work on HDFS-16452:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/22 04:26
Start Date: 17/Feb/22 04:26
Worklog Time Spent: 10m
Work Description: hfutatzhanghb commented on a change in pull request
#3976:
URL: https://github.com/apache/hadoop/pull/3976#discussion_r808664831
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java
##########
@@ -342,7 +342,7 @@ private synchronized void initializeMsync() throws
IOException {
if (msynced) {
return; // No need for an msync
}
- getProxyAsClientProtocol(failoverProxy.getProxy().proxy).msync();
Review comment:
hi， @ayushtkn , thanks a lot for replying.
In class ObserverReadProxyProvider, there are two varaibles used to get
NameNode proxy. One is failoverProxy, another is nameNodeProxies. For read
requests, it will use nameNodeProxies to get a proxy of observer namenode, but
for msync rpc, it will use varaible failoverProxy to get an active namenode
proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 728697)
Time Spent: 40m (was: 0.5h)
> msync RPC should send to Acitve Namenode directly
> --------------------------------------------------
>
> Key: HDFS-16452
> URL: https://issues.apache.org/jira/browse/HDFS-16452
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namanode
> Affects Versions: 3.3.1
> Reporter: zhanghaobo
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In current ObserverReadProxyProvider implementation, we use the following
> code to invoke msync RPC.
> {code:java}
> getProxyAsClientProtocol(failoverProxy.getProxy().proxy).msync(); {code}
> But msync RPC maybe send to Observer NameNode in this way, and then failover
> to Active NameNode. This can be avoid by applying this patch.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
