[
https://issues.apache.org/jira/browse/HDFS-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
tomscut updated HDFS-16458:
---------------------------
Description:
TestNameNodeReconfigure#verifySPSEnabled was compared with
itself({*}isSPSRunning{*}) at assertEquals.
In addition, after an *internal SPS* has been removed, *spsService daemon* will
not start within StoragePolicySatisfyManager. I think the relevant code can be
removed to simplify the code.
IMO, after reconfig SPS mode, we just need to confirm whether the mode is
correct and whether spsManager is NULL.
was:
TestNameNodeReconfigure#verifySPSEnabled was compared with itself(isSPSRunning)
at assertEquals.
In addition, after an *internal SPS* has been removed, *spsService daemon* will
not start within StoragePolicySatisfyManager. I think the relevant code can be
removed to simplify the code.
IMO, after reconfig SPS mode, we just need to confirm whether the mode is
correct and whether spsManager is NULL.
> [SPS]: Fix bug for unit test of reconfiguring SPS mode
> ------------------------------------------------------
>
> Key: HDFS-16458
> URL: https://issues.apache.org/jira/browse/HDFS-16458
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
>
> TestNameNodeReconfigure#verifySPSEnabled was compared with
> itself({*}isSPSRunning{*}) at assertEquals.
> In addition, after an *internal SPS* has been removed, *spsService daemon*
> will not start within StoragePolicySatisfyManager. I think the relevant code
> can be removed to simplify the code.
> IMO, after reconfig SPS mode, we just need to confirm whether the mode is
> correct and whether spsManager is NULL.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
