[
https://issues.apache.org/jira/browse/HDFS-16429?focusedWorklogId=730361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-730361
]
ASF GitHub Bot logged work on HDFS-16429:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/22 13:31
Start Date: 21/Feb/22 13:31
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #4005:
URL: https://github.com/apache/hadoop/pull/4005#issuecomment-1046884710
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 8m 56s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ branch-3.2 Compile Tests _ |
| +0 :ok: | mvndep | 3m 29s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 27m 29s | | branch-3.2 passed |
| +1 :green_heart: | compile | 17m 0s | | branch-3.2 passed |
| +1 :green_heart: | checkstyle | 2m 59s | | branch-3.2 passed |
| +1 :green_heart: | mvnsite | 3m 6s | | branch-3.2 passed |
| +1 :green_heart: | javadoc | 2m 24s | | branch-3.2 passed |
| +1 :green_heart: | spotbugs | 5m 21s | | branch-3.2 passed |
| +1 :green_heart: | shadedclient | 16m 58s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 6s | | the patch passed |
| +1 :green_heart: | compile | 16m 14s | | the patch passed |
| +1 :green_heart: | javac | 16m 14s | | the patch passed |
| +1 :green_heart: | blanks | 0m 1s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 40s | | the patch passed |
| +1 :green_heart: | mvnsite | 2m 49s | | the patch passed |
| +1 :green_heart: | xml | 0m 2s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 14s | | the patch passed |
| +1 :green_heart: | spotbugs | 6m 0s | | the patch passed |
| +1 :green_heart: | shadedclient | 17m 54s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 16m 54s | | hadoop-common in the patch
passed. |
| -1 :x: | unit | 187m 36s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4005/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 4s | | The patch does not
generate ASF License warnings. |
| | | 342m 4s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.namenode.TestFsck |
| | hadoop.hdfs.TestEncryptionZones |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4005/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4005 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell xml |
| uname | Linux 3b34ecfdba4c 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.2 / 200cb42a2b31d15c47f1967daf1db2d129cf9f55 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4005/1/testReport/ |
| Max. process+thread count | 3412 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4005/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 730361)
Time Spent: 2h 10m (was: 2h)
> Add DataSetLockManager to manage fine-grain locks for FsDataSetImpl
> -------------------------------------------------------------------
>
> Key: HDFS-16429
> URL: https://issues.apache.org/jira/browse/HDFS-16429
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Mingxiang Li
> Assignee: Mingxiang Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> 1、Use lockManager to maintain two level lock for FsDataSetImpl.
> The simple lock model like this.Parts of implemented as follows
> * As for finalizeReplica(),append(),createRbw()....First get BlockPoolLock
> read lock，and then get BlockPoolLock-volume-lock write lock.
> * As for getStoredBlock(),getMetaDataInputStream()....First get
> BlockPoolLock read lock，and the then get BlockPoolLock-volume-lock read lock.
> * As for deepCopyReplica(),getBlockReports() get the BlockPoolLock read lock.
> * As for delete hold the BlockPoolLock write lock.
> 2、Make LightWeightResizableGSet become thread safe.It not become performance
> bottleneck if we make it thread safe.We can reduce lock grain size for
> ReplicaMap when make LightWeightResizableGSet thread safe.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
