[
https://issues.apache.org/jira/browse/HDFS-16478?focusedWorklogId=731352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731352
]
ASF GitHub Bot logged work on HDFS-16478:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/22 04:54
Start Date: 23/Feb/22 04:54
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on a change in pull request #4016:
URL: https://github.com/apache/hadoop/pull/4016#discussion_r812559159
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
##########
@@ -1378,7 +1378,7 @@ public long monotonicNow() {
private final BlockingQueue<Runnable> queue;
CommandProcessingThread(BPServiceActor actor) {
- super("Command processor");
+ setName("Command processor-" + getId());
Review comment:
> Putting the NN address in would not disambiguate the logs because they
would all be for the same NN still. It would give more information, sure, but
not actually helpful information.
Sorry I don't this information. IIUC, now each command processor match to
block pool one by one. and actually `nnAddr` includes hostname/port together. I
mean that it could different each other even for MiniDFSCluster framework.
Right? for another way, with nnAddr, it could be helpful to dig when this
thread meet issues.
Anyway, I don't disagree to add getId() also here. We could add both them to
the thread name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 731352)
Time Spent: 1h 10m (was: 1h)
> Multiple command processor threads have same name
> -------------------------------------------------
>
> Key: HDFS-16478
> URL: https://issues.apache.org/jira/browse/HDFS-16478
> Project: Hadoop HDFS
> Issue Type: Task
> Components: datanode
> Reporter: Mike Drob
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When running an in-process MiniDFSCluster with multiple data nodes, the
> command processor threads all share the same name, making them more difficult
> to get debug and logging information from.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
