[
https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187314#comment-13187314
]
Eli Collins commented on HDFS-2768:
-----------------------------------
Hi Uma,
Doesn't seem like classes like BPOfferService need to call
DFSUtil.closeConnectionToNamenode, since all the protocol references refer to
underling *PB classes that will stop the proxy on close, ie just calling
IOUtils#cleanup as they do currently is sufficient (don't need to close and
stopProxy). Ie howabout your latest patch but instead of factoring
closeConnectionToNamenode out of DFSClient keeping that as is (it DFSClient we
don't always have a PB class) and just using calls to IOUtils#cleanup instead?
Thanks,
Eli
> BackupNode stop can not close proxy connections because it is not a proxy
> instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at
> org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at
> org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at
> org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
