[
https://issues.apache.org/jira/browse/HDFS-16458?focusedWorklogId=734285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734285
]
ASF GitHub Bot logged work on HDFS-16458:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 01:33
Start Date: 01/Mar/22 01:33
Worklog Time Spent: 10m
Work Description: tomscut opened a new pull request #4041:
URL: https://github.com/apache/hadoop/pull/4041
JIRA: [HDFS-16458](https://issues.apache.org/jira/browse/HDFS-16458).
**_I resubmitted a PR, because the previous PR
[#3998](https://github.com/apache/hadoop/pull/3998) forgot to set the `issue
ID`._**
TestNameNodeReconfigure#verifySPSEnabled was compared with
itself(`isSPSRunning`) at assertEquals.
In addition, after an `internal SPS `has been removed, `spsService daemon`
will not start within StoragePolicySatisfyManager. I think the relevant code
can be removed to simplify the code.
IMO, after reconfig SPS mode, we just need to confirm whether the mode is
correct and whether spsManager is NULL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 734285)
Time Spent: 1h 20m (was: 1h 10m)
> [SPS]: Fix bug for unit test of reconfiguring SPS mode
> ------------------------------------------------------
>
> Key: HDFS-16458
> URL: https://issues.apache.org/jira/browse/HDFS-16458
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> TestNameNodeReconfigure#verifySPSEnabled was compared with
> itself({*}isSPSRunning{*}) at assertEquals.
> In addition, after an *internal SPS* has been removed, *spsService daemon*
> will not start within StoragePolicySatisfyManager. I think the relevant code
> can be removed to simplify the code.
> IMO, after reconfig SPS mode, we just need to confirm whether the mode is
> correct and whether spsManager is NULL.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
