[
https://issues.apache.org/jira/browse/HDFS-16481?focusedWorklogId=735894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735894
]
ASF GitHub Bot logged work on HDFS-16481:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/22 12:01
Start Date: 03/Mar/22 12:01
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #4028:
URL: https://github.com/apache/hadoop/pull/4028#discussion_r818587730
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestMiniJournalCluster.java
##########
@@ -52,4 +60,92 @@ public void testStartStop() throws IOException {
c.shutdown();
}
}
+
+ @Test
+ public void testStartStopWithPorts() throws Exception {
+ Configuration conf = new Configuration();
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of http ports (1) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(8481).build();
+ });
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of rpc ports (2) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setRpcPorts(8481, 8482).build();
+ });
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of rpc ports (1) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(800, 9000,
10000).setRpcPorts(8481)
+ .build();
+ });
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of http ports (4) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(800, 9000, 1000,
2000)
+ .setRpcPorts(8481, 8482, 8483).build();
+ });
+
+ final Set<Integer> httpAndRpcPorts = NetUtils.getFreeSocketPorts(6);
+ LOG.info("Free socket ports: {}", httpAndRpcPorts);
+
+ final int[] httpPorts = new int[3];
+ final int[] rpcPorts = new int[3];
+ int httpPortIdx = 0;
+ int rpcPortIdx = 0;
+ for (Integer httpAndRpcPort : httpAndRpcPorts) {
+ if (httpPortIdx < 3) {
+ httpPorts[httpPortIdx++] = httpAndRpcPort;
+ } else {
+ rpcPorts[rpcPortIdx++] = httpAndRpcPort;
+ }
+ }
+
+ LOG.info("Http ports selected: {}", httpPorts);
+ LOG.info("Rpc ports selected: {}", rpcPorts);
+
+ for (int i = 0; i < 3; i++) {
+ assertNotEquals(0, rpcPorts[i]);
+ assertNotEquals(0, httpPorts[i]);
+ }
Review comment:
you could have asserted directly on httpAndRpcPorts. :-)
```
assertFalse(httpAndRpcPorts.contains(0));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735894)
Time Spent: 5h 10m (was: 5h)
> Provide support to set Http and Rpc ports in MiniJournalCluster
> ---------------------------------------------------------------
>
> Key: HDFS-16481
> URL: https://issues.apache.org/jira/browse/HDFS-16481
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> We should provide support for clients to set Http and Rpc ports of
> JournalNodes in MiniJournalCluster.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
