[
https://issues.apache.org/jira/browse/HDFS-16500?focusedWorklogId=740628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-740628
]
ASF GitHub Bot logged work on HDFS-16500:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/22 02:27
Start Date: 14/Mar/22 02:27
Worklog Time Spent: 10m
Work Description: smarthanwang commented on pull request #4061:
URL: https://github.com/apache/hadoop/pull/4061#issuecomment-1066274434
> Thanks @smarthanwang involve me here. It almost look good to me. Just one
nit, it seems changes default value here, any consideration? Just suggest keep
it if no any concerns. Thanks again.
@Hexiaoqiao thanks for comment.
When deleting a large directory, the deletion loop would continue for a long
time, if we set the lock holding limit as 500ms, the rpcQueueTime of almost all
rpc requests would increase to 500ms, it's too long for production cluster. So
I think it's better to **set a smaller default value which is not much greater
than the avgRpcQueueTime of our cluster.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 740628)
Time Spent: 1.5h (was: 1h 20m)
> Make asynchronous blocks deletion lock and unlock durtion threshold
> configurable
> ---------------------------------------------------------------------------------
>
> Key: HDFS-16500
> URL: https://issues.apache.org/jira/browse/HDFS-16500
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namanode
> Reporter: Chengwei Wang
> Assignee: Chengwei Wang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I have backport the nice feature HDFS-16043 to our internal branch, it works
> well in our testing cluster.
> I think it's better to make the fields *_deleteBlockLockTimeMs_* and
> *_deleteBlockUnlockIntervalTimeMs_* configurable, so that we can control the
> lock and unlock duration.
> {code:java}
> private final long deleteBlockLockTimeMs = 500;
> private final long deleteBlockUnlockIntervalTimeMs = 100;{code}
> And we should set the default value smaller to avoid blocking other requests
> long time when deleting some large directories.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
