[
https://issues.apache.org/jira/browse/HDFS-16498?focusedWorklogId=747561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747561
]
ASF GitHub Bot logged work on HDFS-16498:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 01:18
Start Date: 25/Mar/22 01:18
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #4057:
URL: https://github.com/apache/hadoop/pull/4057#discussion_r834874623
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -2751,6 +2751,13 @@ public boolean checkBlockReportLease(BlockReportContext
context,
return true;
}
DatanodeDescriptor node = datanodeManager.getDatanode(nodeID);
+ if (node == null) {
+ final UnregisteredNodeException e = new
UnregisteredNodeException(nodeID, null);
+ NameNode.stateChangeLog.error("BLOCK* NameSystem.getDatanode: " + "Data
node " + nodeID +
Review comment:
> I am confused if we need log here which upper method also do that when
meet UnregisteredNodeException. Although it is DEBU level now, we could improve
that to WARN, right?
Thanks @Hexiaoqiao for your review. I will wait for @ayushtkn reply and
decide whether to update again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 747561)
Time Spent: 3h 40m (was: 3.5h)
> Fix NPE for checkBlockReportLease
> ---------------------------------
>
> Key: HDFS-16498
> URL: https://issues.apache.org/jira/browse/HDFS-16498
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2022-03-09-20-35-22-028.png, screenshot-1.png
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> During the restart of Namenode, a Datanode is not registered, but this
> Datanode triggers FBR, which causes NPE.
> !image-2022-03-09-20-35-22-028.png|width=871,height=158!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
