[
https://issues.apache.org/jira/browse/HDFS-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yanbin.zhang updated HDFS-16525:
--------------------------------
Description:
System.err should be used when error occurs in multiple methods in DFSAdmin
class,as follows:
{code:java}
//DFSAdmin#refreshCallQueue
...
try{
proxy.getProxy().refreshCallQueue();
System.out.println("Refresh call queue successful for "
+ proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh call queue failed for "
+ proxy.getAddress());
exceptions.add(ioe);
}
...
{code}
The test method closed first in TestDFSAdminWithHA also needs to be
modified,otherwise an error will be reported,similar to the following:
{code:java}
[ERROR] Failures:
[ERROR]
TestDFSAdminWithHA.testRefreshCallQueueNN1DownNN2Up:726->assertOutputMatches:77
Expected output to match 'Refresh call queue failed for.*
Refresh call queue successful for.*
' but err_output was:
Refresh call queue failed for localhost/127.0.0.1:12876
refreshCallQueue: Call From h110/10.1.234.110 to localhost:12876 failed on
connection exception: java.net.ConnectException: Connection refused; For more
details see: http://wiki.apache.org/hadoop/ConnectionRefused and output was:
Refresh call queue successful for localhost/127.0.0.1:12878{code}
was:
System.err should be used when error occurs in multiple methods in DFSAdmin
class,as follows:
{code:java}
//DFSAdmin#refreshCallQueue
...
try{
proxy.getProxy().refreshCallQueue();
System.out.println("Refresh call queue successful for "
+ proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh call queue failed for "
+ proxy.getAddress());
exceptions.add(ioe);
}
...
{code}
The test method closed first in TestDFSAdminWithHA also needs to be modified,
otherwise an error will be reported:
> System.err should be used when error occurs in multiple methods in DFSAdmin
> class
> ---------------------------------------------------------------------------------
>
> Key: HDFS-16525
> URL: https://issues.apache.org/jira/browse/HDFS-16525
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: dfsadmin
> Affects Versions: 3.3.2
> Reporter: yanbin.zhang
> Assignee: yanbin.zhang
> Priority: Major
>
> System.err should be used when error occurs in multiple methods in DFSAdmin
> class,as follows:
> {code:java}
> //DFSAdmin#refreshCallQueue
> ...
> try{
> proxy.getProxy().refreshCallQueue();
> System.out.println("Refresh call queue successful for "
> + proxy.getAddress());
> }catch (IOException ioe){
> System.out.println("Refresh call queue failed for "
> + proxy.getAddress());
> exceptions.add(ioe);
> }
> ...
> {code}
> The test method closed first in TestDFSAdminWithHA also needs to be
> modified,otherwise an error will be reported,similar to the following:
> {code:java}
> [ERROR] Failures:
> [ERROR]
> TestDFSAdminWithHA.testRefreshCallQueueNN1DownNN2Up:726->assertOutputMatches:77
> Expected output to match 'Refresh call queue failed for.*
> Refresh call queue successful for.*
> ' but err_output was:
> Refresh call queue failed for localhost/127.0.0.1:12876
> refreshCallQueue: Call From h110/10.1.234.110 to localhost:12876 failed on
> connection exception: java.net.ConnectException: Connection refused; For more
> details see: http://wiki.apache.org/hadoop/ConnectionRefused and output was:
> Refresh call queue successful for localhost/127.0.0.1:12878{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]