[ 
https://issues.apache.org/jira/browse/HDFS-16454?focusedWorklogId=755106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755106
 ]

ASF GitHub Bot logged work on HDFS-16454:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 06:31
            Start Date: 11/Apr/22 06:31
    Worklog Time Spent: 10m 
      Work Description: cndaimin commented on code in PR #3982:
URL: https://github.com/apache/hadoop/pull/3982#discussion_r846984707


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -2227,14 +2227,14 @@ public void shutdown() {
     // wait reconfiguration thread, if any, to exit
     shutdownReconfigurationTask();
 
-    LOG.info("Waiting up to 30 seconds for transfer threads to complete");
+    LOG.info("Waiting up to 15 seconds for transfer threads to complete");

Review Comment:
   `executorService.awaitTermination(timeout, unit)` will be possibly invoked 2 
times in `HadoopExecutors#shutdown`. The time value in log looks ok.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755106)
    Time Spent: 0.5h  (was: 20m)

> fix inconsistent comments in DataNode
> -------------------------------------
>
>                 Key: HDFS-16454
>                 URL: https://issues.apache.org/jira/browse/HDFS-16454
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: lujie
>            Priority: Trivial
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It seems that while we fix  https://issues.apache.org/jira/browse/HDFS-7932 , 
> we do not change the corresponding comments. I have created a pull request, 
> please review it and tell me whether it is a problem.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to