[ 
https://issues.apache.org/jira/browse/HDFS-13522?focusedWorklogId=755306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755306
 ]

ASF GitHub Bot logged work on HDFS-13522:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 16:41
            Start Date: 11/Apr/22 16:41
    Worklog Time Spent: 10m 
      Work Description: simbadzina commented on code in PR #4127:
URL: https://github.com/apache/hadoop/pull/4127#discussion_r847532359


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1380,8 +1437,9 @@ private static boolean isExpectedValue(Object 
expectedValue, Object value) {
     final CallerContext originContext = CallerContext.getCurrent();
     for (final T location : locations) {
       String nsId = location.getNameserviceId();
+      boolean isObserverRead = observerReadEnabled && isReadCall(m);
       final List<? extends FederationNamenodeContext> namenodes =
-          getNamenodesForNameservice(nsId);
+          msync(nsId, ugi, isObserverRead);

Review Comment:
   @tomscut for "Here's how we do it.", is there a link you meant to attach?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755306)
    Time Spent: 5h 10m  (was: 5h)

> RBF: Support observer node from Router-Based Federation
> -------------------------------------------------------
>
>                 Key: HDFS-13522
>                 URL: https://issues.apache.org/jira/browse/HDFS-13522
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: federation, namenode
>            Reporter: Erik Krogen
>            Assignee: Simbarashe Dzinamarira
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HDFS-13522.001.patch, HDFS-13522.002.patch, 
> HDFS-13522_WIP.patch, RBF_ Observer support.pdf, Router+Observer RPC 
> clogging.png, ShortTerm-Routers+Observer.png
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Changes will need to occur to the router to support the new observer node.
> One such change will be to make the router understand the observer state, 
> e.g. {{FederationNamenodeServiceState}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to