[
https://issues.apache.org/jira/browse/HDFS-16535?focusedWorklogId=757365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757365
]
ASF GitHub Bot logged work on HDFS-16535:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/22 09:14
Start Date: 15/Apr/22 09:14
Worklog Time Spent: 10m
Work Description: leosunli commented on code in PR #4158:
URL: https://github.com/apache/hadoop/pull/4158#discussion_r851165931
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java:
##########
@@ -957,6 +958,83 @@ public void testDomainSocketClosedByDN() throws Exception {
}
}
+ // Regression test for HDFS-16473
Review Comment:
I don't quite understand the connection between this UT and HDFS-16473.
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java:
##########
@@ -240,7 +245,7 @@ public void run() {
} else {
shm.getEndpointShmManager().shutdown(shm);
IOUtilsClient.cleanupWithLogger(LOG, domainSocket, out);
- domainSocket = null;
Review Comment:
why do you remove the line 243? If remove it, the line 228 looks redundant.
Issue Time Tracking
-------------------
Worklog Id: (was: 757365)
Time Spent: 1h (was: 50m)
> SlotReleaser should reuse the domain socket based on socket paths
> -----------------------------------------------------------------
>
> Key: HDFS-16535
> URL: https://issues.apache.org/jira/browse/HDFS-16535
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 3.3.1, 3.4.0
> Reporter: Quanlong Huang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> HDFS-13639 improves the performance of short-circuit shm slot releasing by
> reusing the domain socket that the client previously used to send release
> request to the DataNode.
> This is good when there are only one DataNode locates with the client (truth
> in most of the production environment). However, if we launch multiple
> DataNodes on a machine (usually for testing, e.g. Impala's end-to-end tests),
> the request could be sent to the wrong DataNode. See an example in
> IMPALA-11234.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
