[
https://issues.apache.org/jira/browse/HDFS-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525412#comment-17525412
]
Hemanth Boyina commented on HDFS-16531:
---------------------------------------
[~hexiaoqiao]{color:#172b4d} IMO in FSDirAttrOp#unprotectedSetReplication
while comparing the source and target replication we are not actually comparing
it with file replication, but also with Max replication which exists in file
diffs, can you go through this
https://issues.apache.org/jira/browse/HDFS-16548?focusedCommentId=17525115&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17525115{color}
> Avoid setReplication logging an edit record if old replication equals the new
> value
> -----------------------------------------------------------------------------------
>
> Key: HDFS-16531
> URL: https://issues.apache.org/jira/browse/HDFS-16531
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I recently came across a NN log where about 800k setRep calls were made,
> setting the replication from 3 to 3 - ie leaving it unchanged.
> Even in a case like this, we log an edit record, an audit log, and perform
> some quota checks etc.
> I believe it should be possible to avoid some of the work if we check for
> oldRep == newRep and jump out of the method early.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
