[
https://issues.apache.org/jira/browse/HDFS-16468?focusedWorklogId=761929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761929
]
ASF GitHub Bot logged work on HDFS-16468:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/22 17:31
Start Date: 25/Apr/22 17:31
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4228:
URL: https://github.com/apache/hadoop/pull/4228#discussion_r857865439
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/cat/cat.cc:
##########
@@ -62,7 +62,6 @@ int main(int argc, char *argv[]) {
//wrapping file_raw into a unique pointer to guarantee deletion
std::unique_ptr<hdfs::FileHandle> file(file_raw);
- ssize_t total_bytes_read = 0;
Review Comment:
We don't use this?
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c:
##########
@@ -487,10 +488,10 @@ static ssize_t wildcard_expandPath(const char* path,
char* expanded)
* allocated after using this function with expandedClasspath=NULL to get the
* right size.
*/
-static ssize_t getClassPath_helper(const char *classpath, char*
expandedClasspath)
+static x_platform_ssize_t getClassPath_helper(const char *classpath, char*
expandedClasspath)
{
- ssize_t length;
- ssize_t retval;
+ x_platform_ssize_t length;
Review Comment:
Is this the best way to do this? Can't we just do the typedef for windows?
Issue Time Tracking
-------------------
Worklog Id: (was: 761929)
Time Spent: 2h (was: 1h 50m)
> Define ssize_t for Windows
> --------------------------
>
> Key: HDFS-16468
> URL: https://issues.apache.org/jira/browse/HDFS-16468
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Some C/C++ files use *ssize_t* data type. This isn't available for Windows
> and we need to define an alias for this and set it to *long long* to make it
> cross platform compatible.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
