[
https://issues.apache.org/jira/browse/HDFS-16465?focusedWorklogId=767678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767678
]
ASF GitHub Bot logged work on HDFS-16465:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/22 11:23
Start Date: 08/May/22 11:23
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on code in PR #4279:
URL: https://github.com/apache/hadoop/pull/4279#discussion_r867475612
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/hdfs_ioservice_test.cc:
##########
@@ -94,7 +94,6 @@ TEST(IoServiceTest, SimplePost) {
EXPECT_EQ(result, "hello from IoService");
service->Stop();
-
Review Comment:
I'll undo this change before merging this PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 767678)
Time Spent: 1h 10m (was: 1h)
> Remove redundant strings.h inclusions
> -------------------------------------
>
> Key: HDFS-16465
> URL: https://issues.apache.org/jira/browse/HDFS-16465
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> *strings.h* was included in a bunch of C/C++ files and are redundant in its
> usage. Also, strings.h is not available on Windows and thus isn't
> cross-platform compatible. Thus, these inclusions of strings.h must be
> removed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
