[
https://issues.apache.org/jira/browse/HDFS-16582?focusedWorklogId=773065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773065
]
ASF GitHub Bot logged work on HDFS-16582:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/22 00:19
Start Date: 21/May/22 00:19
Worklog Time Spent: 10m
Work Description: jojochuang commented on code in PR #4323:
URL: https://github.com/apache/hadoop/pull/4323#discussion_r878603680
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerJsonReport.java:
##########
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hdfs.server.blockmanagement;
+
+import java.util.SortedSet;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.hadoop.classification.InterfaceAudience;
+
+/**
+ * This structure is a thin wrapper over slow peer reports to make Json
+ * [de]serialization easy.
+ */
[email protected]
+final class SlowPeerJsonReport {
Review Comment:
this class is adapted from the subclass ReportForJson in SlowPeerTracker.
Issue Time Tracking
-------------------
Worklog Id: (was: 773065)
Time Spent: 50m (was: 40m)
> Expose aggregate latency of slow node as perceived by the reporting node
> ------------------------------------------------------------------------
>
> Key: HDFS-16582
> URL: https://issues.apache.org/jira/browse/HDFS-16582
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When any datanode is reported to be slower by another node, we expose the
> slow node as well as the reporting nodes list for the slow node. However, we
> don't provide latency numbers of the slownode as reported by the reporting
> node. Having the latency exposed in the metrics would be really helpful for
> operators to keep a track of how far behind a given slow node is performing
> compared to the rest of the nodes in the cluster.
> The operator should be able to gather aggregated latencies of all slow nodes
> with their reporting nodes in Namenode metrics.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
