[ 
https://issues.apache.org/jira/browse/HDFS-16595?focusedWorklogId=775649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775649
 ]

ASF GitHub Bot logged work on HDFS-16595:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/May/22 08:07
            Start Date: 28/May/22 08:07
    Worklog Time Spent: 10m 
      Work Description: virajjasani commented on code in PR #4357:
URL: https://github.com/apache/hadoop/pull/4357#discussion_r884094166


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSlowPeerTracker.java:
##########
@@ -79,9 +79,12 @@ public void testEmptyReports() {
 
   @Test
   public void testReportsAreRetrieved() {
-    tracker.addReport("node2", "node1", 1.2);
-    tracker.addReport("node3", "node1", 2.1);
-    tracker.addReport("node3", "node2", 1.22);
+    OutlierMetrics outlierMetrics1 = new OutlierMetrics(0.0, 0.0, 0.0, 1.2);

Review Comment:
   Sorry I didn't get it. It's already `outlierMetrics1` :)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 775649)
    Time Spent: 1h 10m  (was: 1h)

> Slow peer metrics - add median, mad and upper latency limits
> ------------------------------------------------------------
>
>                 Key: HDFS-16595
>                 URL: https://issues.apache.org/jira/browse/HDFS-16595
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Slow datanode metrics include slow node and it's reporting node details. With 
> HDFS-16582, we added the aggregate latency that is perceived by the reporting 
> nodes.
> In order to get more insights into how the outlier slownode's latencies 
> differ from the rest of the nodes, we should also expose median, median 
> absolute deviation and the calculated upper latency limit details.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to