[
https://issues.apache.org/jira/browse/HDFS-16610?focusedWorklogId=776306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776306
]
ASF GitHub Bot logged work on HDFS-16610:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/22 13:02
Start Date: 31/May/22 13:02
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #4384:
URL: https://github.com/apache/hadoop/pull/4384#discussion_r885609952
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java:
##########
@@ -273,6 +273,14 @@ public interface HdfsClientConfigKeys {
String DFS_LEASE_HARDLIMIT_KEY = "dfs.namenode.lease-hard-limit-sec";
long DFS_LEASE_HARDLIMIT_DEFAULT = 20 * 60;
+ String DFS_CLIENT_FSCK_CONNECT_TIMEOUT_MS =
+ "dfs.client.fsck.connect.timeout.ms";
+ int DFS_CLIENT_FSCK_CONNECT_TIMEOUT_MS_DEFAULT = 60 * 1000;
+
+ String DFS_CLIENT_FSCK_READ_TIMEOUT_MS =
+ "dfs.client.fsck.read.timeout.ms";
+ int DFS_CLIENT_FSCK_READ_TIMEOUT_MS_DEFAULT = 60 * 1000;
Review Comment:
do you want to restrict the config to `ms`? Can keep only
``dfs.client.fsck.connect.timeout`` similar to
``dfs.webhdfs.socket.connect-timeout`` and allow timeunits?
Issue Time Tracking
-------------------
Worklog Id: (was: 776306)
Time Spent: 20m (was: 10m)
> Make fsck read timeout configurable
> -----------------------------------
>
> Key: HDFS-16610
> URL: https://issues.apache.org/jira/browse/HDFS-16610
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In a cluster with a lot of small files, we encountered a case where fsck was
> very slow. I believe it is due to contention with many other threads reading
> / writing data on the cluster.
> Sometimes fsck does not report any progress for more than 60 seconds and the
> client times out. Currently the connect and read timeout are hardcoded to 60
> seconds. This change is to make them configurable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
