[
https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=779075&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779075
]
ASF GitHub Bot logged work on HDFS-16623:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 12:55
Start Date: 07/Jun/22 12:55
Worklog Time Spent: 10m
Work Description: ZanderXu commented on PR #4409:
URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1148630372
Thanks @cnauroth for your comment. Do you mean to add a UT to test that
`getLifelineWaitTime()` can only return non-negative numbers?
I think if we need a UT, we should test the LifelineSender thread exit, but
it is difficult to judge whether the thread exits or not. Do you have some good
ideas? Thanks
Issue Time Tracking
-------------------
Worklog Id: (was: 779075)
Time Spent: 0.5h (was: 20m)
> IllegalArgumentException in LifelineSender
> ------------------------------------------
>
> Key: HDFS-16623
> URL: https://issues.apache.org/jira/browse/HDFS-16623
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In our production environment, an IllegalArgumentException occurred in the
> LifelineSender at one DataNode which was undergoing GC at that time.
> And the bug code is at line 1060 in BPServiceActor.java, because the sleep
> time is negative.
> {code:java}
> while (shouldRun()) {
> try {
> if (lifelineNamenode == null) {
> lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr);
> }
> sendLifelineIfDue();
> Thread.sleep(scheduler.getLifelineWaitTime());
> } catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> } catch (IOException e) {
> LOG.warn("IOException in LifelineSender for " + BPServiceActor.this,
> e);
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
