[
https://issues.apache.org/jira/browse/HDFS-16600?focusedWorklogId=779077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779077
]
ASF GitHub Bot logged work on HDFS-16600:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 13:06
Start Date: 07/Jun/22 13:06
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on PR #4367:
URL: https://github.com/apache/hadoop/pull/4367#issuecomment-1148648304
@ZanderXu Thanks for the great catch here.
It is indeed missed method which need to improve. cc @MingXiangLi @ZanderXu
would you mind to check if other methods also leave this issues?
> Thank you for your contribution, but I still have some concerns about
[HDFS-16534](https://issues.apache.org/jira/browse/HDFS-16534). I feel that for
a new feature, multiple prs should not be used to fix the problem separately,
which makes the code very difficult to read. I recommend creating it under
[HDFS-15382](https://issues.apache.org/jira/browse/HDFS-15382) A subtask to fix
[HDFS-16598](https://issues.apache.org/jira/browse/HDFS-16598) and
[HDFS-16600](https://issues.apache.org/jira/browse/HDFS-16600) together.
@slfan1989 Thansk for your suggestions. IMO, this is not the blocker issue.
Any tickets will be collected to subtask of HDFS-16534 before checkin for
committers. -1 to combine HDFS-16598 and HDFS-16600 together. IIUC, it is
recommended to add/fix one issue for one ticket. Welcome to any more
discussions.
@ZanderXu @slfan1989 Thanks again.
Issue Time Tracking
-------------------
Worklog Id: (was: 779077)
Time Spent: 2h 10m (was: 2h)
> Deadlock on DataNode
> --------------------
>
> Key: HDFS-16600
> URL: https://issues.apache.org/jira/browse/HDFS-16600
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The UT
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.testSynchronousEviction
> failed, because happened deadlock, which is introduced by
> [HDFS-16534|https://issues.apache.org/jira/browse/HDFS-16534].
> DeadLock:
> {code:java}
> // org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.createRbw line 1588
> need a read lock
> try (AutoCloseableLock lock = lockManager.readLock(LockLevel.BLOCK_POOl,
> b.getBlockPoolId()))
> // org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.evictBlocks line
> 3526 need a write lock
> try (AutoCloseableLock lock = lockManager.writeLock(LockLevel.BLOCK_POOl,
> bpid))
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
