[
https://issues.apache.org/jira/browse/HDFS-16590?focusedWorklogId=779692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779692
]
ASF GitHub Bot logged work on HDFS-16590:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/22 22:45
Start Date: 08/Jun/22 22:45
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4349:
URL: https://github.com/apache/hadoop/pull/4349#issuecomment-1150485882
> 1. leave assertEquals alone. I don't care whether it's deprecated or not
-it is not going to be removed.
> 2. new tests should use AssertJ's assertThat for anything complex...it's a
great design and we are adopting it broadly.
> 3. This patch is getting dangerously close to the "create backport pain
for no reason" class of patch. Just because something is mark as deprecated
doesn't mean we have to worry, not unless they're going to remove it
completely. If that happens on a JUnit version upgrade we can deal with it then.
> 4. And if the plan really is to move off deprecated JUnit, the switch MUST
be to assertJ; there is so little use of Junit assertThat that it is isolated.
>
> Overall: I am really unsure whether we really want to do this. It's a
minor cleanup that creates pain. If you really want to go ahead with it then
>
> 1. move to assertj
> 2. do it in a module by module basis.
> 3. Remember that any change which goes near hadoop-aws and hadoop-azure
what is required to be tested against the endpoint of that organisation.
Thank you very much for your suggestion, it helped me a lot. From a personal
point of view, I still hope that the old deprecated method can be replaced by a
new method, which can make the code better.
1. I will replace the deprecated Junit assertThat with assertJ assertThat.
2. Modifications to imports will be minimal.
3. I will repair it module by module.
Thanks again!!!
Issue Time Tracking
-------------------
Worklog Id: (was: 779692)
Time Spent: 2.5h (was: 2h 20m)
> Fix Junit Test Deprecated assertThat
> ------------------------------------
>
> Key: HDFS-16590
> URL: https://issues.apache.org/jira/browse/HDFS-16590
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
