[
https://issues.apache.org/jira/browse/HDFS-16627?focusedWorklogId=779979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779979
]
ASF GitHub Bot logged work on HDFS-16627:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/22 14:24
Start Date: 09/Jun/22 14:24
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on code in PR #4419:
URL: https://github.com/apache/hadoop/pull/4419#discussion_r893570312
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java:
##########
@@ -816,7 +816,7 @@ void register(NamespaceInfo nsInfo) throws IOException {
// off disk - so update the bpRegistration object from that info
DatanodeRegistration newBpRegistration = bpos.createRegistration();
- LOG.info(this + " beginning handshake with NN");
+ LOG.info("{} beginning handshake with NN:{}", this, nnAddr);
Review Comment:
Please keep the same format of log, such as delete the blank at end of a
sentence, leave one blank between two words. such as,
L819: `LOG.info("{} beginning handshake with NN: {}", this, nnAddr);`
L831: `LOG.info("Problem connecting to server: {}", nnAddr);`
Issue Time Tracking
-------------------
Worklog Id: (was: 779979)
Time Spent: 0.5h (was: 20m)
> improve BPServiceActor#register Log Add NN Addr
> -----------------------------------------------
>
> Key: HDFS-16627
> URL: https://issues.apache.org/jira/browse/HDFS-16627
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When I read the log, I think the Addr information of NN should be added to
> make the log information more complete.
> The log is as follows:
> {code:java}
> 2022-06-06 06:15:32,715 [BP-1990954485-172.17.0.2-1654496132136 heartbeating
> to localhost/127.0.0.1:42811] INFO datanode.DataNode
> (BPServiceActor.java:register(819)) - Block pool
> BP-1990954485-172.17.0.2-1654496132136 (Datanode Uuid
> 7d4b5459-6f2b-4203-bf6f-d31bfb9b6c3f) service to localhost/127.0.0.1:42811
> beginning handshake with NN.
> 2022-06-06 06:15:32,717 [BP-1990954485-172.17.0.2-1654496132136 heartbeating
> to localhost/127.0.0.1:42811] INFO datanode.DataNode
> (BPServiceActor.java:register(847)) - Block pool
> BP-1990954485-172.17.0.2-1654496132136 (Datanode Uuid
> 7d4b5459-6f2b-4203-bf6f-d31bfb9b6c3f) service to localhost/127.0.0.1:42811
> successfully registered with NN. {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
