[
https://issues.apache.org/jira/browse/HDFS-16469?focusedWorklogId=780638&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780638
]
ASF GitHub Bot logged work on HDFS-16469:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/22 17:30
Start Date: 12/Jun/22 17:30
Worklog Time Spent: 10m
Work Description: GauthamBanasandra opened a new pull request, #4434:
URL: https://github.com/apache/hadoop/pull/4434
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
The `protoc-gen-hrpc` executable is supposed to be found at
`${CMAKE_CURRENT_BINARY_DIR}/protoc-gen-hrpc`.
https://github.com/apache/hadoop/blob/652b257478f723a9e119e5e9181f3c7450ac92b5/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/proto/CMakeLists.txt#L70
This works so long as we're building the `Release` build. Since we can only
build `RelWithDebInfo` on Windows, the protoc-gen-hrpc binary will be placed at
${CMAKE_CURRENT_BINARY_DIR}/RelWithDebInfo/protoc-gen-hrpc.exe. Hadoop would
need to locate this binary in order to generate the Protobuf headers.
### Solution
We resolve this issue by using the `$<TARGET_FILE:...>` CMake generator
expression to get the path to the `protoc-gen-hrpc` CMake target.
### How was this patch tested?
Hadoop Jenkins CI.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
Issue Time Tracking
-------------------
Worklog Id: (was: 780638)
Remaining Estimate: 0h
Time Spent: 10m
> Locate protoc-gen-hrpc across platforms
> ---------------------------------------
>
> Key: HDFS-16469
> URL: https://issues.apache.org/jira/browse/HDFS-16469
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp
> Time Spent: 10m
> Remaining Estimate: 0h
>
> protoc-gen-hrpc.exe is supposed to be found at
> [${CMAKE_CURRENT_BINARY_DIR}/protoc-gen-hrpc|https://github.com/apache/hadoop/blob/652b257478f723a9e119e5e9181f3c7450ac92b5/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/proto/CMakeLists.txt#L70].
> This works so long as we're building the Release build. Since we can only
> build RelWithDebInfo on Windows, the protoc-gen-hrpc binary will be placed at
> {*}${CMAKE_CURRENT_BINARY_DIR}/RelWithDebInfo/protoc-gen-hrpc.exe{*}. Hadoop
> would need to locate this binary in order to generate the Protobuf headers.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
