[
https://issues.apache.org/jira/browse/HDFS-16634?focusedWorklogId=782508&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782508
]
ASF GitHub Bot logged work on HDFS-16634:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/22 18:42
Start Date: 17/Jun/22 18:42
Worklog Time Spent: 10m
Work Description: tomscut commented on code in PR #4448:
URL: https://github.com/apache/hadoop/pull/4448#discussion_r900424477
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerTracker.java:
##########
@@ -80,7 +80,7 @@ public class SlowPeerTracker {
* Number of nodes to include in JSON report. We will return nodes with
* the highest number of votes from peers.
*/
- private final int maxNodesToReport;
+ private int maxNodesToReport;
Review Comment:
Please set this to `volatile`. Although it doesn't make a big difference
here, I think it's better to be consistent with other reconfig changes. What do
you think of this?
Issue Time Tracking
-------------------
Worklog Id: (was: 782508)
Time Spent: 0.5h (was: 20m)
> Dynamically adjust slow peer report size on JMX metrics
> -------------------------------------------------------
>
> Key: HDFS-16634
> URL: https://issues.apache.org/jira/browse/HDFS-16634
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> On a busy cluster, sometimes it takes bit of time for deleted node(from the
> cluster)'s "slow node report" to get removed from slow peer json report on
> Namenode JMX metrics. In the meantime, user should be able to browse through
> more entries in the report by adjusting i.e. reconfiguring
> "dfs.datanode.max.nodes.to.report" so that the list size can be adjusted
> without user having to bounce active Namenode just for this purpose.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
