[
https://issues.apache.org/jira/browse/HDFS-16616?focusedWorklogId=782826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782826
]
ASF GitHub Bot logged work on HDFS-16616:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/22 06:40
Start Date: 20/Jun/22 06:40
Worklog Time Spent: 10m
Work Description: PrabhuJoseph commented on PR #4400:
URL: https://github.com/apache/hadoop/pull/4400#issuecomment-1160036052
Thanks @Samrat002 for the patch. Looks good to me. WIll commit it tomorrow
morning if no other comments.
Issue Time Tracking
-------------------
Worklog Id: (was: 782826)
Time Spent: 1h (was: 50m)
> Remove the use if Sets#newHashSet and Sets#newTreeSet
> ------------------------------------------------------
>
> Key: HDFS-16616
> URL: https://issues.apache.org/jira/browse/HDFS-16616
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Samrat Deb
> Assignee: Samrat Deb
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> As part of removing guava dependencies HADOOP-17115, HADOOP-17721,
> HADOOP-17722 and HADOOP-17720 are fixed,
> Currently the code call util function to create HashSet and TreeSet in the
> repo . These function calls dont have much importance as it is calling
> internally new HashSet<> / new TreeSet<> from java.utils
> This task is to clean up all the function calls to create sets which is
> redundant
> Before moving to java8 , sets were created using guava functions and API ,
> now since this is moved away and util code in the hadoop now looks like
> 1.
> public static <E extends Comparable> TreeSet<E> newTreeSet() { return new
> TreeSet<E>();
> 2.
> public static <E> HashSet<E> newHashSet()
> { return new HashSet(); }
> These interfaces dont do anything much just a extra layer of function call
> please refer to the task
> https://issues.apache.org/jira/browse/HADOOP-17726
> Can anyone review if this ticket add some value in the code.
> Looking forward to some input/ thoughts . If not adding any value we can
> close it and not move forward with changes !
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
