[
https://issues.apache.org/jira/browse/HDFS-13274?focusedWorklogId=788394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788394
]
ASF GitHub Bot logged work on HDFS-13274:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/22 20:33
Start Date: 06/Jul/22 20:33
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4531:
URL: https://github.com/apache/hadoop/pull/4531#discussion_r915232277
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -541,6 +541,28 @@ public static <T> ProtocolProxy<T>
getProtocolProxy(Class<T> protocol,
return getProtocolProxy(protocol, clientVersion, addr, ticket, conf,
factory, getRpcTimeout(conf), null);
}
+
+ /**
+ * Get a protocol proxy that contains a proxy connection to a remote server
+ * and a set of methods that are supported by the server
+ *
+ * @param protocol protocol class
+ * @param clientVersion client version
+ * @param connId client connection identifier
+ * @param conf configuration
+ * @param factory socket factory
+ * @return the protocol proxy
+ * @throws IOException if the far end through a RemoteException
+ */
+ public static <T> ProtocolProxy<T> getProtocolProxy(Class<T> protocol,
Review Comment:
Fix the javadocs.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1760,7 +1760,7 @@ UserGroupInformation getTicket() {
return ticket;
}
- private int getRpcTimeout() {
Review Comment:
Can we do the HADOOP changes in a separate PR with a HADOOP JIRA?
Something like "Allow socket factory for connections"
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcEngine.java:
##########
@@ -57,6 +57,11 @@ <T> ProtocolProxy<T> getProxy(Class<T> protocol,
SocketFactory factory, int rpcTimeout,
RetryPolicy connectionRetryPolicy) throws IOException;
+ /** Construct a client-side proxy object using a ConnectionId. */
Review Comment:
Let's add the full javadoc.
Issue Time Tracking
-------------------
Worklog Id: (was: 788394)
Time Spent: 0.5h (was: 20m)
> RBF: Extend RouterRpcClient to use multiple sockets
> ---------------------------------------------------
>
> Key: HDFS-13274
> URL: https://issues.apache.org/jira/browse/HDFS-13274
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HADOOP-13144 introduces the ability to create multiple connections for the
> same user and use different sockets. The RouterRpcClient should use this
> approach to get a better throughput.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
