[
https://issues.apache.org/jira/browse/HDFS-16648?focusedWorklogId=789353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789353
]
ASF GitHub Bot logged work on HDFS-16648:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/22 01:58
Start Date: 11/Jul/22 01:58
Worklog Time Spent: 10m
Work Description: ZanderXu commented on code in PR #4529:
URL: https://github.com/apache/hadoop/pull/4529#discussion_r917489534
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java:
##########
@@ -518,10 +517,7 @@ public void
selectInputStreams(Collection<EditLogInputStream> streams,
// the cache used for RPC calls is not enabled; fall back to using the
// streaming mechanism to serve such requests
if (inProgressOk && inProgressTailingEnabled) {
- if (LOG.isDebugEnabled()) {
Review Comment:
Thanks @slfan1989 for your review.
Removing `LOG.isDebugEnabled()` can save a redundant judgment.
Please refer to https://www.slf4j.org/faq.html#logging_performance to get
some detailed information. Thanks
You can also refer to HDFS-14103 and HDFS-16638.
Issue Time Tracking
-------------------
Worklog Id: (was: 789353)
Time Spent: 2.5h (was: 2h 20m)
> Normalize the usage of debug logs in NameNode
> ---------------------------------------------
>
> Key: HDFS-16648
> URL: https://issues.apache.org/jira/browse/HDFS-16648
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> There are many irregular debug logs in NameNode. such as:
> Error type1:
> {code:java}
> if (LOG.isDebugEnabled()) {
> LOG.debug("Getting groups for user " + user);
> }
> {code}
> we can format it to:
> {code:java}
> LOG.debug("Getting groups for user {}. ", user);
> {code}
> Error type2:
> {code:java}
> LOG.debug("*DIR* NameNode.renameSnapshot: Snapshot Path {}, " +
> "snapshotOldName {}, snapshotNewName {}", snapshotRoot,
> snapshotOldName, snapshotNewName);
> {code}
> we can format it to:
> {code:java}
> if (LOG.isDebugEnabled()) {
> LOG.debug("*DIR* NameNode.renameSnapshot: Snapshot Path {}, " +
> "snapshotOldName {}, snapshotNewName {}", snapshotRoot,
> snapshotOldName, snapshotNewName);
> }
> {code}
> Error type3:
> {code:java}
> if (LOG.isDebugEnabled()) {
> LOG.debug("getAdditionalDatanode: src=" + src
> + ", fileId=" + fileId
> + ", blk=" + blk
> + ", existings=" + Arrays.asList(existings)
> + ", excludes=" + Arrays.asList(excludes)
> + ", numAdditionalNodes=" + numAdditionalNodes
> + ", clientName=" + clientName);
> }
> {code}
> We can format it to:
> {code:java}
> if (LOG.isDebugEnabled()) {
> LOG.debug("getAdditionalDatanode: src={}, fileId={}, "
> + "blk={}, existings={}, excludes={}, numAdditionalNodes={}, "
> + "clientName={}.", src, fileId, blk, Arrays.asList(existings),
> Arrays.asList(excludes), numAdditionalNodes, clientName);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
