[ 
https://issues.apache.org/jira/browse/HDFS-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ZanderXu updated HDFS-16658:
----------------------------
    Description: 
During locating some abnormal cases in our prod environment, I found that 
BlockManager does not out put some logs in `addStoredBlock` even though 
`logEveryBlock` is true.

I feel that we need to change the log level from DEBUG to INFO.


{code:java}
// Some comments here
private Block addStoredBlock(final BlockInfo block,
                               final Block reportedBlock,
                               DatanodeStorageInfo storageInfo,
                               DatanodeDescriptor delNodeHint,
                               boolean logEveryBlock)
  throws IOException {
    ....
      if (logEveryBlock) {
        blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
            node, storedBlock, storedBlock.getNumBytes());
      }
    ...
  }
{code}

  was:
During locating some abnormal cases in our prod environment, I found that 
BlockManager does not out put some logs in `addStoredBlock` even though 
`logEveryBlock` is true.

I feel that we need to change the log level from DEBUG to INFO.


{code:java}
// Some comments here
private Block addStoredBlock(final BlockInfo block,
                               final Block reportedBlock,
                               DatanodeStorageInfo storageInfo,
                               DatanodeDescriptor delNodeHint,
                               boolean logEveryBlock)
  throws IOException {
    ....
      if (logEveryBlock) {
        blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
            node, storedBlock, storedBlock.getNumBytes());
      }
    ...
  }


> BlockManager should output some logs when logEveryBlock is true.
> ----------------------------------------------------------------
>
>                 Key: HDFS-16658
>                 URL: https://issues.apache.org/jira/browse/HDFS-16658
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Minor
>
> During locating some abnormal cases in our prod environment, I found that 
> BlockManager does not out put some logs in `addStoredBlock` even though 
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>                                final Block reportedBlock,
>                                DatanodeStorageInfo storageInfo,
>                                DatanodeDescriptor delNodeHint,
>                                boolean logEveryBlock)
>   throws IOException {
>     ....
>       if (logEveryBlock) {
>         blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
>             node, storedBlock, storedBlock.getNumBytes());
>       }
>     ...
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to